fix(install): derive VLLM_VER from VLLM_REF when --vllm-ref is passed#7649
fix(install): derive VLLM_VER from VLLM_REF when --vllm-ref is passed#7649AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
Conversation
When --vllm-ref is passed via CLI, VLLM_VER should be derived from VLLM_REF to ensure consistent version handling across the script. This fixes issues where --vllm-ref updates were not reflected in GitHub release wheel URLs, PyPI install strings, and hotfix version checks. Fixes ai-dynamo#7420 Signed-off-by: Asad Shahid <asad.shahid@berkeley.edu>
|
👋 Hi AsadShahid04! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe script now derives Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fixed by #7584 |
When --vllm-ref is passed via CLI, VLLM_VER should be derived from VLLM_REF to ensure consistent version handling across the script. This fixes issues where --vllm-ref updates were not reflected in GitHub release wheel URLs, PyPI install strings, and hotfix version checks.
Fixes #7420
Summary by CodeRabbit