Skip to content

fix(install): derive VLLM_VER from VLLM_REF when --vllm-ref is passed#7649

Closed
AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
AsadShahid04:fix/inf-issue-7420
Closed

fix(install): derive VLLM_VER from VLLM_REF when --vllm-ref is passed#7649
AsadShahid04 wants to merge 1 commit intoai-dynamo:mainfrom
AsadShahid04:fix/inf-issue-7420

Conversation

@AsadShahid04
Copy link
Copy Markdown
Contributor

@AsadShahid04 AsadShahid04 commented Mar 26, 2026

When --vllm-ref is passed via CLI, VLLM_VER should be derived from VLLM_REF to ensure consistent version handling across the script. This fixes issues where --vllm-ref updates were not reflected in GitHub release wheel URLs, PyPI install strings, and hotfix version checks.

Fixes #7420

Summary by CodeRabbit

  • Bug Fixes
    • Corrected version string handling when using custom vllm references to prevent installation mismatches.

When --vllm-ref is passed via CLI, VLLM_VER should be derived from
VLLM_REF to ensure consistent version handling across the script.
This fixes issues where --vllm-ref updates were not reflected in
GitHub release wheel URLs, PyPI install strings, and hotfix version
checks.

Fixes ai-dynamo#7420

Signed-off-by: Asad Shahid <asad.shahid@berkeley.edu>
@AsadShahid04 AsadShahid04 requested a review from a team March 26, 2026 04:38
@AsadShahid04 AsadShahid04 requested review from a team as code owners March 26, 2026 04:38
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi AsadShahid04! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor backend::vllm Relates to the vllm backend container labels Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b05c4c78-d597-4491-8a81-3494ded21e46

📥 Commits

Reviewing files that changed from the base of the PR and between a58bcc3 and ca2e980.

📒 Files selected for processing (1)
  • container/deps/vllm/install_vllm.sh

Walkthrough

The script now derives VLLM_VER by stripping a leading v from the VLLM_REF argument when provided, ensuring version consistency across downstream operations. Previously, VLLM_VER remained hardcoded at its default value, causing mismatches in wheel URL construction and pip install version selection.

Changes

Cohort / File(s) Summary
vLLM installation script
container/deps/vllm/install_vllm.sh
When --vllm-ref is passed, VLLM_VER is now derived by stripping the leading v from VLLM_REF (e.g., v0.18.00.18.0), ensuring version consistency across wheel URLs, pip install strings, and hotfix patch checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: deriving VLLM_VER from VLLM_REF when the --vllm-ref CLI argument is passed.
Description check ✅ Passed The description addresses the core issue, explains the problem solved, and links to the related GitHub issue (#7420), though it omits optional sections from the template.
Linked Issues check ✅ Passed The PR directly addresses the primary requirement in issue #7420 by deriving VLLM_VER from VLLM_REF when --vllm-ref is provided, fixing downstream version mismatches.
Out of Scope Changes check ✅ Passed The single-line change is directly scoped to fixing the issue reported in #7420 with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rmccorm4
Copy link
Copy Markdown
Contributor

rmccorm4 commented Apr 9, 2026

Fixed by #7584

@rmccorm4 rmccorm4 closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::vllm Relates to the vllm backend container external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: VLLM_VER not updated when --vllm-ref is passed in install_vllm.sh

2 participants