Skip to content

Feature recto verso adjustment for two page mode#1391

Open
aw-cloud wants to merge 2 commits intoahrm:developmentfrom
aw-cloud:feature_recto_verso_adjustment
Open

Feature recto verso adjustment for two page mode#1391
aw-cloud wants to merge 2 commits intoahrm:developmentfrom
aw-cloud:feature_recto_verso_adjustment

Conversation

@aw-cloud
Copy link
Copy Markdown
Contributor

Documents with missing pages, especially title pages and covers, can end up with the pages flipped so that recto pages are incorrectly displayed on the left and vice versa. This PR adds an offset and associated command to toggle the offset so documents can be correctly displayed.

PR also fixes some typos I found along the way. Let me know what you think.

aw-cloud added 2 commits May 11, 2025 18:29
Documents with missing pages, especially title pages and covers, can end
up with the pages flipped so that recto pages are incorrectly displayed
on the left and vice versa. This commit adds an offset and associated
command to toggle the offset so documents can be correctly displayed
ahrm added a commit that referenced this pull request May 13, 2025
@ahrm
Copy link
Copy Markdown
Owner

ahrm commented May 13, 2025

Thanks, I like the idea but I think it is better if it is a config rather than command (that way, if the user is reading a long book that requires adjustment they can temporarily set it in their config file so they don't have to readjust it every time, though it does mean that it is a global config for all files which might not be what the user wants but I might add per-file configs in the future which will solve this issue.). I have added it in eb03410 as a config.

@aw-cloud
Copy link
Copy Markdown
Contributor Author

That makes sense. I tend to work with lots of files so a command suits my workflow better but I can understand how the change being nonpersistent could get annoying if you mostly read one thing at a time. Per-file configs would be nice if that's the easiest way to get both persistence and a toggle.

aw-cloud pushed a commit to aw-cloud/sioyek that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants