Change how goto_beginning, goto_top handle scrolling#1073
Change how goto_beginning, goto_top handle scrolling#10737415963987456321 wants to merge 3 commits intoahrm:mainfrom
Conversation
Should clarify the code, makes it easier to find if it is correctly spelled
This implements goto_beginning() and simplifies the goto_end() function
|
Did not occur to me to check the development branch, at a quick glance it seems like these changes have not yet been implemented on there, will rebase these changes onto developer and test further. |
|
Hope this PR gets merged. I also find it annoying how the However, I don't think it's a good idea to change how number repeats offsets the page. Having e.g. |
Good point, don't generally use that feature of vim, or sioyek for that matter, just had a look at how vim is handling this, and I agree that this PR should behave the same way. Will revisit this at a later date when I have the time. |
Similar to the issue in #1039 but not quite the same since this PR only affects the commands.
Currently when navigating to the top/bottom of the page using keyboard or entering command, sioyek will scroll past the page edge, I found this bothersome and I see no benefit to scrolling past the page like that.