ci: add github actions by Khady · Pull Request #12 · ahrefs/esgg

Khady · 2025-11-10T10:54:25Z

Probably needs to be updated. For an unknown reason I created the branch but not a corresponding PR at the time.

Khady · 2025-11-10T11:11:38Z

using https://github.com/Khady/modern-ocaml/tree/main/.github as template

rr0gi · 2025-11-13T21:10:33Z

i don't have opinion on this and i cannot read yaml so merge when you see fit

The _shards type was added to search results in PR #15 but the test expected outputs were not regenerated. Update all test output.atd files to match the current code generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Implements GitHub issue #5. The multi_terms aggregation groups documents by multiple fields simultaneously (like SQL GROUP BY a, b), returning composite keys as JSON arrays. Changes: - common.ml: Add Tuple variant to result_type for composite keys - aggregations.ml: Add Multi_terms variant, parsing, and type inference - atdgen.ml: Map Tuple to ATD tuple type (serialized as JSON array) - test/multi_terms_agg: Test with keyword and numeric fields, variable size The composite key is represented as an ATD tuple, which naturally maps to JSON arrays matching the ES multi_terms response format. Closes #5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Include shard failure details (reason type+text, shard, index, node, status) as optional fields in the generated _shards ATD type for Search queries, matching the ES ShardStatistics spec: - failures: optional (may be absent even when failed > 0) - reason: required on each failure (ErrorCause) - reason.type: required string (becomes type_ in OCaml) - reason.reason: optional string (human-readable message) - shard, index, node, status: all optional Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

All search query output.atd files updated to include the new reason, failure types and expanded _shards type. Get/Mget tests unaffected. Note: other_bucket gains failure (shard) and failure1 (aggregation bucket) types — automatic deduplication when a query already had a field named 'failure' in its aggregations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Support $(var:field:<type>) syntax alongside existing $(var:list). No behavioral changes yet — field_type is parsed but unused. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Field_var carries a Tjson.var and a simple_type parsed from the field type annotation. typeof_value returns Simple typ directly, bypassing the mapping lookup. Also adds parse_field_type helper to convert user-facing type strings ("string", "int", "float", "int64") to simple_type. Note: the value type definition was moved after pp_simple_type because [@@deriving show] on Field_var needs the printer in scope. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Parse $(var:field:<type>) in aggregation field position - Register field variables as string input parameters - Skip numeric/date field validation for dynamic fields Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Tests $(group_by:field:string) syntax: verifies string input parameter and string bucket key output type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add field variable section under Variables with usage example and supported type annotations.

Use descriptive names like _typ, _name, _metric, _keys etc. instead of bare _ in pattern matches added by this PR.

Type annotations now use ES type names (keyword, long, double) instead of custom names (string, int, float). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The :field: segment was redundant — the type annotation is useful regardless of context, and the usage site already determines semantics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The annotated type is known at codegen time, so we can warn when a non-numeric type is used in a numeric context — same as Field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Eliminates redundant second match on aggregation type. Each arm now handles its own field_var_constraints inline, matching the existing pattern for on_int_var and Field_num/Field_date constraints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

String is the type of the variable value (field name passed at runtime), not the aggregation result type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

External users don't know what simple_of_es_type is. List supported types directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The field is no longer field-specific after the syntax simplification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The parser branches already prevent this, but the explicit check makes the invariant visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Tests $(bucket_field:long) in a histogram aggregation, exercising the Field_num constraint validation path and float bucket key output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add variable field support in aggregations

rr0gi · 2026-03-27T14:47:30Z

+let ends_with s suffix =
+  let s_len = Stdlib.String.length s in
+  let suffix_len = Stdlib.String.length suffix in
+  s_len >= suffix_len
+  && Stdlib.String.sub s (s_len - suffix_len) suffix_len = suffix


but i have an opinion on copy-pasting stdlib functions inline multiple times and you don't want to hear it

Khady · 2026-03-30T03:50:41Z

sorry I had an agent running in a loop to fix the CI and wasn't looking at all at its output, I should have switched to draft PR before to run it. Still haven't done a human review of the changes

Atlas07 and others added 23 commits March 9, 2026 19:53

Regenerate test outputs after _shards addition (#15)

b504f59

The _shards type was added to search results in PR #15 but the test expected outputs were not regenerated. Update all test output.atd files to match the current code generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Mark multi_terms as supported in README

2710b48

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add field_type to Tjson.var record and extend variable parser

181a211

Support $(var:field:<type>) syntax alongside existing $(var:list). No behavioral changes yet — field_type is parsed but unused. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add regression test for field variable in terms aggregation

fd4e59c

Tests $(group_by:field:string) syntax: verifies string input parameter and string bucket key output type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Document $(var:field:<type>) syntax in README

66e50ab

Add field variable section under Variables with usage example and supported type annotations.

Replace bare _ wildcards with named wildcards for readability

d713514

Use descriptive names like _typ, _name, _metric, _keys etc. instead of bare _ in pattern matches added by this PR.

Reuse simple_of_es_type instead of separate parse_field_type

8e044e4

Type annotations now use ES type names (keyword, long, double) instead of custom names (string, int, float). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Simplify variable syntax from $(var:field:<type>) to $(var:<type>)

45a09a6

The :field: segment was redundant — the type annotation is useful regardless of context, and the usage site already determines semantics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Validate Field_var type in Field_num constraint

5ae15fc

The annotated type is known at codegen time, so we can warn when a non-numeric type is used in a numeric context — same as Field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add clarifying comment to field_var_constraints Eq_type String

465917e

String is the type of the variable value (field name passed at runtime), not the aggregation result type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove internal function reference from README

6c14bde

External users don't know what simple_of_es_type is. List supported types directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Rename field_type to type_ in Tjson.var

e20ff5b

The field is no longer field-specific after the syntax simplification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Assert list and type_ are mutually exclusive in make_var

af75b0f

The parser branches already prevent this, but the explicit check makes the invariant visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add regression test for numeric-type field variable in histogram

93f14c3

Tests $(bucket_field:long) in a histogram aggregation, exercising the Field_num constraint validation path and float bucket key output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge pull request #18 from Atlas07/field-var-aggregations

357d5ac

Add variable field support in aggregations

ci: add github actions

b76337d

ci: update tested OCaml versions

334565f

Khady force-pushed the louis/ci branch from 212f0b9 to 334565f Compare March 27, 2026 07:53

Khady added 4 commits March 27, 2026 08:11

ci: fix warning 6 in ci_build profile

f6b29a1

ci: qualify atd AST types in interface

220bafb

ci: avoid fragile atd full_module alias

7847da4

ci: infer atdgen interface from implementation

ff141d1

Khady added 2 commits March 27, 2026 08:30

ci: constrain atd to v2

94fd40c

ci: avoid extlib ends_with API drift

1f0a856

rr0gi reviewed Mar 27, 2026

View reviewed changes

rr0gi force-pushed the master branch 2 times, most recently from fe4d76e to 131cba2 Compare March 27, 2026 16:21

Khady marked this pull request as draft March 30, 2026 03:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add github actions#12

ci: add github actions#12
Khady wants to merge 29 commits intomasterfrom
louis/ci

Khady commented Nov 10, 2025

Uh oh!

Khady commented Nov 10, 2025

Uh oh!

rr0gi commented Nov 13, 2025

Uh oh!

rr0gi Mar 27, 2026

Uh oh!

Khady commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Khady commented Nov 10, 2025

Uh oh!

Khady commented Nov 10, 2025

Uh oh!

rr0gi commented Nov 13, 2025

Uh oh!

rr0gi Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Khady commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants