Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
io.agentscope:agentscope-parent:pom:1.0.12-SNAPSHOT
Description
Background
Some skill repositories (for example Nacos) encode the skill source with a colon, such as nacos:public.
AgentSkill#getSkillId()is built as name + "_" + source, so the id can contain :. On Windows, : is not allowed in a normal path segment, so
SkillBox#uploadSkillFiles()could fail to write resources when it used Path#resolve(skillId) as a directory name.Solution
Keep logical identifiers (
getSource(),getSkillId()) unchanged, while making filesystem paths used during skill file upload safeon Windows (and generally for reserved filename characters).
Checklist
• Add
SkillBox.unifyToSafeSkillIdto normalize characters that are invalid in file names (\ / : * ? " < > |) to _, with a smallfallback for blank ids.
• Use the normalized id only when constructing upload directory paths in
uploadSkillFiles().mvn spotless:applymvn test)