fix(core): enable pending tool recovery by default#1182
Open
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(core): enable pending tool recovery by default#1182Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this fix
When a ReActAgent session is restored with pending tool calls that never produced results, the existing PendingToolRecoveryHook can repair the state before the next call. The builder currently leaves that hook disabled by default, so a normal follow-up message can still fail with IllegalStateException after session restore. Enabling the recovery hook by default matches the documented behavior and preserves explicit opt-out support.
Validation
Closes [Bug]:agentscope agent as tools模式下流式场景报错：Cannot add messages without tool results when pending tool calls exist. #918.