Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
io.agentscope:agentscope-parent:pom:1.0.12-SNAPSHOT
Description
LongTermMemory will block the agent when the LLM stops responding. This commit enables the framework to record long term memory asynchronously.
Added
longTermMemoryAsyncRecordoption toReActAgent.Builderto support fire-and-forget long-term memory recording inSTATIC_CONTROL/BOTHmode.When enabled, the
StaticLongTermMemoryHookperformsrecord()asynchronously without blocking the agent's response, reducing latency inSTATIC_CONTROLmode. Agent-controlled recording (AGENT_CONTROL) remains synchronous.Checklist
Please check the following items before code is ready to be reviewed.
ReActAgent.Builder— newlongTermMemoryAsyncRecord(boolean)setterStaticLongTermMemoryHook— overloaded constructor acceptingasyncRecordflag;handlePostCall()splits sync/async pathsStaticLongTermMemoryHookTest— added 3 async recording test casesCode has been formatted with
mvn spotless:applyAll tests are passing (
mvn test)Javadoc comments are complete and follow project conventions
Related documentation has been updated (e.g. links, examples, etc.)
Code is ready for review