fix(core): mirror summary thinking into reasoning events#1169
Open
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(core): mirror summary thinking into reasoning events#1169Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
Contributor
Author
|
Rebased this PR onto the current |
34b83be to
c30e8b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThinkingBlockchunks intoReasoningChunkEventSummaryChunkEventbehavior for summary streaming intactWhy this fix
ReActAgentuses a dedicated summary streaming path after max-iteration fallback. In that path, a streamedThinkingBlockcurrently only triggersSummaryChunkEvent, even though the same provider/model behavior is exposed asReasoningChunkEventin normal reasoning streams.That breaks the hook abstraction for clients that render reasoning exclusively from
ReasoningChunkEvent, especially with models likeqwen3.5-plusthat may place thinking deltas inside the summary stream.This patch keeps summary hooks working as before, while also mirroring summary-phase thinking chunks into
ReasoningChunkEventwith accumulated thinking content.Fixes #1152.
Validation
mvn -pl :agentscope-core -am spotless:applymvn -pl :agentscope-core -am "-Dtest=ReActAgentSummaryThinkingHookTest" testmvn -pl :agentscope-core -am "-Dtest=ReActAgentTest,ReActAgentThinkingCumulativeTest,ReActAgentSummaryThinkingHookTest" test