Skip to content

ci: upload coverage to Codecov #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nficano merged 1 commit into from
May 25, 2026
+14 −2
Merged

ci: upload coverage to Codecov #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,20 @@ jobs:
- name: Build
run: ./gradlew --no-daemon assemble

- name: Test
run: ./gradlew --no-daemon test
- name: Test (with Kover coverage)
run: ./gradlew --no-daemon test koverXmlReport
Comment on lines +74 to +75
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Run koverVerify in CI to enforce coverage thresholds.

The new command generates XML but skips threshold enforcement, so coverage regressions won’t fail CI despite build.gradle.kts defining verify bounds. Please include koverVerify in this step.

Suggested patch 
-      - name: Test (with Kover coverage)
-        run: ./gradlew --no-daemon test koverXmlReport
+      - name: Test (with Kover coverage)
+        run: ./gradlew --no-daemon test koverXmlReport koverVerify
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Test (with Kover coverage)
run: ./gradlew --no-daemon test koverXmlReport
- name: Test (with Kover coverage)
run: ./gradlew --no-daemon test koverXmlReport koverVerify
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/test.yml around lines 74 - 75, The CI step "Test (with
Kover coverage)" currently runs "./gradlew --no-daemon test koverXmlReport"
which generates XML but does not enforce coverage limits; update that step to
also run "koverVerify" (e.g., "./gradlew --no-daemon test koverXmlReport
koverVerify" or add a follow-up run invoking koverVerify) so the Gradle task
koverVerify is executed and coverage thresholds defined in build.gradle.kts are
enforced.


# Aggregated Kover XML lives at build/reports/kover/report.xml in the
# root project (see build.gradle.kts kover { } block, which depends on
# lib + tests). Non-blocking so a Codecov outage cannot break CI.
- name: Upload coverage to Codecov
# codecov/codecov-action v6.0.1
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1
with:
fail_ci_if_error: false
flags: unittests
files: ./build/reports/kover/report.xml
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test reports
if: failure()
Expand Down
Loading