fix(schema): infer integer type for Nimble enum choices#611
Closed
mhsdef wants to merge 1 commit intoagentjido:mainfrom
Closed
fix(schema): infer integer type for Nimble enum choices#611mhsdef wants to merge 1 commit intoagentjido:mainfrom
mhsdef wants to merge 1 commit intoagentjido:mainfrom
Conversation
When a Nimble `:in` type contains all integer choices, the generated JSON schema now correctly uses `"type": "integer"` instead of always defaulting to `"type": "string"`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Omg. Need to run these more locally first. Maybe we need both? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a Nimble
:intype contains all integer choices (e.g.{:in, [1, 2, 3]}), the generated JSON schema now correctly emits"type": "integer"instead of always defaulting to"type": "string".Type of Change
Breaking Changes
N/A
Testing
mix test)mix quality)Checklist
CHANGELOG.md(it is auto-generated by git_ops)Related Issues
N/A