chore(hack): add golangci-lint to developer and CI workflows#63
Open
Davanum Srinivas (dims) wants to merge 1 commit into
Open
chore(hack): add golangci-lint to developer and CI workflows#63Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
Davanum Srinivas (dims)
force-pushed
the
chore/add-golangci-lint
branch
3 times, most recently
from
c728700 to
9cff48b
Compare
Adds golangci-lint v2.12.2 using the per-tool-module pattern under hack/tools/golangci-lint/. The verifier at hack/verify/golangci-lint.sh is auto-discovered by hack/verify-all.sh, so the existing CI verify step picks it up with no workflow YAML change. Ships .golangci.yaml with the standard linter set, make lint and make lint-fix targets, and a verify wrapper that pins GOOS=linux so ateom-gvisor's netlink references typecheck on macOS the same way they do on CI. Adjustments to keep the first run clean: two dead-code deletions ((*runsc).cmdList, MemoryPullCache.gcsClient), two SA9003 empty branches replaced with slog.Warn / t.Logf, one S1008 return-bool simplification, and inline //nolint for one intentional best-effort ReleaseLock plus five audit-tracked SA1019 deprecations. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Davanum Srinivas (dims)
force-pushed
the
chore/add-golangci-lint
branch
from
9cff48b to
670f635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds golangci-lint v2.12.2 using the existing per-tool-module pattern. The new verifier is auto-discovered by
hack/verify-all.sh, so the existingverifystep inpr-workflow.yamlruns it — no workflow YAML changes.hack/tools/golangci-lint/,hack/{,verify/,update/}golangci-lint.sh..golangci.yamlwith the standard linter set (errcheck,govet,ineffassign,staticcheck,unused).make lintandmake lint-fix.//nolintfor six audit-tracked or intentional sites.