cleanup: use a cache for JWT/CA instead of reading from disk every time#17
Open
Yuval Kohavi (yuval-k) wants to merge 2 commits into
Open
cleanup: use a cache for JWT/CA instead of reading from disk every time#17Yuval Kohavi (yuval-k) wants to merge 2 commits into
Yuval Kohavi (yuval-k) wants to merge 2 commits into
Conversation
For sessionIDJWTPoolFile, sessionIDCAPoolFile check modification time, and if not changed, use cached value.
Collaborator
|
This looks good, but actually I think we probably don't even need to check mtimes --- it's probably sufficient to just check if the keys have changed every 5 minutes or so. Root key rotations are not part of the normal operation of the system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to fix re-reading the JWT keys and CAs every-time.
For sessionIDJWTPoolFile, sessionIDCAPoolFile check modification time, and if not changed, use cached value.