chore: sync core lib and CLAUDE.md from agent-core#8
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated synchronization of the core library files and the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, an automated sync from agent-core, updates CLAUDE.md and lib/collectors/git.js. The changes in lib/collectors/git.js involve renaming git-map to repo-intel and updating the data structure returned by collectGitData. While most changes are additive, the removal of the commitShape object and the modification of the conventions object introduce breaking changes. I've left a comment highlighting the potential risk for downstream consumers that may not have been updated to handle this new data structure.
| conventions: { | ||
| style: conventions.style || null, | ||
| prefixes: conventions.prefixes || {}, | ||
| scopes: conventions.scopes || {} | ||
| usesScopes: conventions.usesScopes || false | ||
| }, |
There was a problem hiding this comment.
The structure of the conventions object has changed from scopes to usesScopes. Additionally, the commitShape object has been removed entirely from the data returned by collectGitData. These are breaking changes that could cause runtime errors in downstream consumers that expect the old structure. Please ensure that all consumers of this function's output have been updated to handle this new data shape.
Automated sync of lib/ and CLAUDE.md from agent-core.