Skip to content

ENH: visual overhaul, macaca templates, and new validation features#252

Open
ataha24 wants to merge 1 commit intomasterfrom
enh/ui-and-macaca-support
Open

ENH: visual overhaul, macaca templates, and new validation features#252
ataha24 wants to merge 1 commit intomasterfrom
enh/ui-and-macaca-support

Conversation

@ataha24
Copy link
Copy Markdown
Member

@ataha24 ataha24 commented Mar 16, 2026

UI/Visual:

  • Complete CSS redesign with Space Mono font, scanline overlay, glow animations, and consistent dark/green design system
  • Responsive hero page with live template stats, how-it-works workflow, feature grid, and template browser
  • Validator page redesigned: drag-and-drop file zone, styled selects, animated submit button, dev-mode login notice
  • Larger AFIDs banner (clamp 360–620px)

Validation features:

  • Regional radar chart (error profile across 8 neuroanatomical regions)
  • Directional error language per landmark (e.g. "2.1mm posterior")
  • Session summary dashboard: mean±SD, best/worst landmark, within-2mm count
  • Color-coded distance table (green/amber/red by threshold)

Macaca support:

  • Add afids-templates/macaca/ with 6 mean consensus FCSV templates: D99, INIA19, MacaqueMNI, NMTv1.3, NMTv2.0asym, Yerkes19
  • Templates sourced from afids/afids-macaca PHASE1_output_afid
  • Species dropdown now includes Macaca alongside Human

Proposed changes

Describe the changes implemented in this pull request. If the changes fix a bug or resolves a feature request, be sure to link the issue. Please explain the issue and how the changes address the issue.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

UI/Visual:
- Complete CSS redesign with Space Mono font, scanline overlay, glow
  animations, and consistent dark/green design system
- Responsive hero page with live template stats, how-it-works workflow,
  feature grid, and template browser
- Validator page redesigned: drag-and-drop file zone, styled selects,
  animated submit button, dev-mode login notice
- Larger AFIDs banner (clamp 360–620px)

Validation features:
- Regional radar chart (error profile across 8 neuroanatomical regions)
- Directional error language per landmark (e.g. "2.1mm posterior")
- Session summary dashboard: mean±SD, best/worst landmark, within-2mm count
- Color-coded distance table (green/amber/red by threshold)

Macaca support:
- Add afids-templates/macaca/ with 6 mean consensus FCSV templates:
  D99, INIA19, MacaqueMNI, NMTv1.3, NMTv2.0asym, Yerkes19
- Templates sourced from afids/afids-macaca PHASE1_output_afid
- Species dropdown now includes Macaca alongside Human
<span class="stat-green">{{ summary.n_within_2mm }}</span>
<span style="font-size:1rem; color:var(--muted);">/{{ summary.total }}</span>
</div>
<div class="summary-stat-sub">{{ summary.n_within_1mm }} within 1mm</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appears after the summary which is a little confusing -- consider moving it after 'WITHIN 2 MM' sentence

<span style="font-size:1rem; color:var(--muted);">/{{ summary.total }}</span>
</div>
<div class="summary-stat-sub">{{ summary.n_within_1mm }} within 1mm</div>
<div class="summary-stat-label">Within 2mm</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mm appears as MM in the GUI -- better if it stays lowercase

@Dhananjhay
Copy link
Copy Markdown

It looks really good! Left some minor comments + revision notes but overall should be good to be merged. I tested the new design using a sample fscv and it worked just fine. Amazing work @ataha24!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants