Prevent rendering fetch results arriving out of order#151
Open
til wants to merge 1 commit intoafcapel:mainfrom
Open
Prevent rendering fetch results arriving out of order#151til wants to merge 1 commit intoafcapel:mainfrom
til wants to merge 1 commit intoafcapel:mainfrom
Conversation
Before, a slow server response arriving after the response to a later request would cause outdated results to be rendered. Example sequence of events: 1. user types "ab", request for q=ab starts 2. user types "cd", request for q=abcd starts 3. response for q=abcd arrives and is rendered 4. response for q=ab arrives and should be discarded
✅ Deploy Preview for stimulus-autocomplete canceled.
|
Author
|
I should add that I've experienced this behaviour in production on a server with high variability in search response time (20ms-1000ms) and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, a slow server response arriving after the response to a later request would cause outdated results to be rendered.
Example sequence of events:
I've reproduced it locally with a test server that echos the search with "You searched for ..." and artificially delays the response to
q=abby 2s. At the end of the video, it shows "You searched for ab", but it should show "You searched for abcd".Give me a hint how to test this with cypress and I can give it a try. Something with
interceptreturning a promise?Somewhat related to #137 .