Closed
Conversation
When the min length value is set to 0, the autocomplete will not fetch
the data from the server. This is a problem when a consumer wants to
also show something when the input is empty.
For example, it would unblock the following use case:
```html
<input
name="search"
data-autocomplete-target="input"
data-autocomplete-url-value="/search?q={q}"
data-autocomplete-min-length-value="0"
data-action="focusin->autocomplete#onInputChange"
/>
```
in which some results are shown as soon as the input is focused.
✅ Deploy Preview for stimulus-autocomplete canceled.
|
Author
|
Seems it didn't gain traction. |
|
Any updates on merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the min length value is set to 0, the autocomplete will not fetch the data from the server. This is a problem when a consumer wants to also show something when the input is empty.
For example, it would unblock the following use case:
in which some results are shown as soon as the input is focused.
It's a simple way to address the "fetch on focus" issue and an alternative to "fetch on focus" PR.