feat(classify): add --fail-fast + colored err#70
Open
MrDwarf7 wants to merge 4 commits into
Open
Conversation
MrDwarf7
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5018c74. Configure here.
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
MrDwarf7
force-pushed
the
mrdwarf7/cli-options-2
branch
from
4a38204 to
5018c74
Compare
- engine.ts: replace execSync (returns string, not {stdout,stderr}) with
spawnSync which properly captures both streams. Removes broken
"as unknown as" cast and shell interpolation hack.
- bookmarks-viz.ts: define ANSI_RE as regex literal instead of
constructing from ESC constant (literal [ opened a character class).
- md-export.ts: accept ISO dates with time components by checking
dash positions (>=10 length) instead of strict length===10.
Addresses Cursor Bugbot comments on afar1#70.
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
--fail-fastflag toft classifycommand to stop on first error, plus colored error output for better CLI UX.Benefits
--fail-fastallows users to see errors immediately without processing all bookmarks.gitignoreupdated to exclude*.logfiles from classification outputChanges
src/cli.ts: Added--fail-fastboolean option to classify commandsrc/engine.ts: Implement fail-fast logic in classification enginesrc/bookmark-classify-llm.ts: Add error output styling with chalk/redsrc/bookmarks-viz.ts: Update to use new error display approachDocs
Updated README with the new
--fail-fastoption documentation.Stacked Note
This PR is stacked on top of my other submission ( #69 ) which adds the
--formatflag to themdcommand.(noice)
Note
Medium Risk
Medium risk because it changes LLM process invocation/error handling (
invokeEngine) and classification control flow, which could affect all LLM-backed commands and how failures are detected/handled.Overview
Adds a
--fail-fastoption toft classifyandft classify-domains, wiring it through the LLM classification pipeline to stop after the first batch error and printing clearer, colored error messages.Updates LLM engine invocation to capture and surface
stdout/stderrin a structuredInvokeErrorand to treat engine output containingERROR:as a failure.Extends
ft mdwith--formatto control exported markdown filenames (new reverse-ISO-style default with day-of-week, pluslegacy), and updates README/CLAUDE.mdlocal-run guidance and.gitignoreto ignorepnpm*.Reviewed by Cursor Bugbot for commit 5018c74. Bugbot is set up for automated code reviews on this repo. Configure here.