Adds lots of stuff to Scene objects and adds Layout level staining support.#1727
Merged
Haselnussbomber merged 18 commits intoaers:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
Author
yes thank you that's by design |
Haselnussbomber
requested changes
Feb 18, 2026
Collaborator
Haselnussbomber
left a comment
There was a problem hiding this comment.
Just a quick glance at it.
It would also require you to add the functions and vfuncs to the data.yml once you're good with the names.
Contributor
Author
|
Alright, light stuff added, feedback addressed and |
wolfcomp
requested changes
Mar 7, 2026
Co-authored-by: wolfcomp <4028289+wolfcomp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Common::Math::SphereBounds,Common::Math::OrientedBounds, andCommon::Math::AxisAlignedBoundsmath types. I did not update the few places that useVector4for sphere bounds instead ofSphereBounds.Adds vfuncs for Scene object updates, computing the 3 types of bounds, hit testing, working with attach bones, and dither transparency. Also added an enum for the Dtor mode so we can standardize that a bit. Tested the 3 bounds querying (some cases are wonky e.g. characters with oriented and aligned bounds, but I believe that's a sqenix problem), both hit test methods, and dither transparency (SE only implemented it for
BgObjects). Did not test the attach bone stuff.Adds the static Create helpers for
BgObjectandVfxObject, stain support forBgObject, and some VFX fields from OGT. Tested that I can create and destroy both, and set VFX color andBgObjectstain.Adds support for staining
SharedGroupLayoutInstances and in general viaILayoutInstance.ApplyStain. I have not tested these myself.