[CLIENT-4350] Add runtime flag /RTC1 to raise an error when uninitialized read occurs

.github/workflows/build-and-run-dev-tests-with-windows-python-dbg.yml

@@ -0,0 +1,78 @@
+on:
+  workflow_call:
+  workflow_dispatch:
+  pull_request:
+
+jobs:
+  windows-python-dbg:
+    runs-on: ["self-hosted", "Windows", "X64"]
+    steps:
+    - name: Harden the runner (Audit all outbound calls)
+      uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
+      with:
+        egress-policy: audit
+
+    - name: Get tests and Github action scripts
+      uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+      with:
+        ref: ${{ inputs.use_jfrog_builds && inputs.jfrog-build-version-to-test || github.sha }}
+        submodules: recursive
+        # Always required for versioningit to work when building
+        # TODO: maybe move to a single config file
+        fetch-depth: 0
+
+    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+      with:
+        repository: python/cpython
+        submodules: recursive
+        path: cpython
+
+    # Why install from source:
+    # 1. Not using pyenv, because I believe pyenv is more suited for user installations. Installing on Github Actions
+    # means installing as administrator. When doing so, pyenv could not be called automatically even after setting the PATH.
+    # 2. Using the legacy Python install wizard to install in debug mode fails with error code 1 as well.
+    # 3. The newer Python install manager doesn't have a Python debug build available for Windows
+    - run: ./build.bat -d
+      working-directory: cpython/PCbuild
+
+    - run: |
+        pydebug_abs_path="$(realpath PCbuild/amd64/)"
+        echo $(cygpath -w "$pydebug_abs_path") >> $GITHUB_PATH
+      shell: bash
+      working-directory: cpython
+
+    - uses: ./.github/actions/run-ee-server
+      with:
+        # registry-name: ${{ inputs.registry-name }}
+        registry-username: ${{ secrets.DOCKER_HUB_BOT_USERNAME }}
+        registry-password: ${{ secrets.DOCKER_HUB_BOT_PW }}
+        # image-name: ${{ inputs.image-name }}
+        # server-tag: ${{ inputs.server-tag }}
+        where-is-client-connecting-from: 'remote-connection'
+
+    - name: 'Windows: Add msbuild to PATH'
+      uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2.0.0
+
+    - name: 'Windows: Install C client deps'
+      run: |
+        choco install --yes nuget.commandline
+        nuget restore
+      working-directory: aerospike-client-c/vs
+
+    - name: Install wheel
+      run: |
+        # pip isn't included by default here
+        python_d -m ensurepip --upgrade
+        python_d -m pip install build -c requirements.txt
+        python_d -m build
+        python_d -m pip install dist/*.whl
+      env:
+        UNOPTIMIZED: 1
+
+    - name: Install test dependencies
+      run: python_d -m pip install pytest -c requirements.txt
+      working-directory: test
+
+    - name: Run tests
+      run: python_d -m pytest new_tests/
+      working-directory: test

.github/workflows/stage-tests.yml

@@ -258,3 +258,6 @@
       if: ${{ matrix.runner-os-and-arch[1] == 'arm64' }}
       run: python3 -c "import aerospike"
       working-directory: test
+
+  windows-dbg:
+    uses: .github/workflows/build-and-run-dev-tests-with-windows-python-dbg.yml

setup.py

@@ -68,7 +68,7 @@
     ['/usr/local/opt/openssl/include'] + \
     ['aerospike-client-c/modules/common/src/include']
 extra_compile_args = [
-    '-std=gnu99', '-g', '-Wall', '-fPIC', '-DDEBUG', '-O1',
+    '-std=gnu99', '-g', '-Wall', '-fPIC', '-DDEBUG',
     '-fno-common', '-fno-strict-aliasing',
     '-D_FILE_OFFSET_BITS=64', '-D_REENTRANT',
     '-DMARCH_' + machine,
@@ -119,8 +119,15 @@
     extra_compile_args.append('-ftest-coverage')
     extra_link_args.append('-lgcov')
 
+data_files = []
+
 if UNOPTIMIZED:
-    extra_compile_args.append('-O0')
+    if WINDOWS:
+        extra_compile_args.append('/Zi')
+        extra_link_args.append('/DEBUG')
+        # data_files.append("*.pdb")
+    else:
+        extra_compile_args.append('-O0')
 
 ################################################################################
 # STATIC SSL LINKING BUILD SETTINGS
@@ -140,6 +147,11 @@
 ################################################################################
 
 if WINDOWS:
+    if UNOPTIMIZED:
+        VS_PROJECT_CONFIGURATION = "Debug"
+    else:
+        VS_PROJECT_CONFIGURATION = "Release"
+
     AEROSPIKE_C_TARGET = AEROSPIKE_C_HOME
     tree = ET.parse(f"{AEROSPIKE_C_TARGET}/vs/aerospike/packages.config")
     packages = tree.getroot()
@@ -166,8 +178,13 @@
     libraries = libraries + ['rt']
     AEROSPIKE_C_TARGET = AEROSPIKE_C_HOME + '/target/Linux-' + machine
 elif WINDOWS:
-    libraries.append("pthreadVC2")
+    if UNOPTIMIZED:
+        libraries.append("pthreadVC2d")
+    else:
+        libraries.append("pthreadVC2")
     extra_compile_args.append("-DAS_SHARED_IMPORT")
+    extra_compile_args.append("/O0")
+    extra_compile_args.append("/RTC1")
     include_dirs.append(f"{AEROSPIKE_C_TARGET}/vs/packages/aerospike-client-c-dependencies.{c_client_dependencies_version}/build/native/include")
 else:
     print("error: OS not supported:", PLATFORM, file=sys.stderr)
@@ -184,9 +201,9 @@
     ]
 else:
     include_dirs.append(AEROSPIKE_C_TARGET + '/src/include')
-    library_dirs.append(f"{AEROSPIKE_C_TARGET}/vs/packages/aerospike-client-c-dependencies.{c_client_dependencies_version}/build/native/lib/x64/Release")
+    library_dirs.append(f"{AEROSPIKE_C_TARGET}/vs/packages/aerospike-client-c-dependencies.{c_client_dependencies_version}/build/native/lib/x64/{VS_PROJECT_CONFIGURATION}")
     # Needed for linking the Python client with the C client
-    extra_objects.append(AEROSPIKE_C_TARGET + "/vs/x64/Release/aerospike.lib")
+    extra_objects.append(AEROSPIKE_C_TARGET + f"/vs/x64/{VS_PROJECT_CONFIGURATION}/aerospike.lib")
 
 os.putenv('CPATH', ':'.join(include_dirs))
 os.environ['CPATH'] = ':'.join(include_dirs)
@@ -230,7 +247,7 @@ def clean():
             cmd = [
                 'msbuild',
                 'vs/aerospike.sln',
-                '/property:Configuration=Release'
+                f"/property:Configuration={VS_PROJECT_CONFIGURATION}"
             ]
         else:
             cmd = [
@@ -324,5 +341,6 @@ def clean():
     cmdclass={
         'build': CClientBuild,
         'clean': CClientClean
-    }
+    },
+    data_files=data_files
 )