Skip to content

[CLIENT-4436] Add quality-of-life improvements for path expressions#1002

Open
juliannguyen4 wants to merge 108 commits intodevfrom
CLIENT-4436-path-expressions-improvements
Open

[CLIENT-4436] Add quality-of-life improvements for path expressions#1002
juliannguyen4 wants to merge 108 commits intodevfrom
CLIENT-4436-path-expressions-improvements

Conversation

@juliannguyen4
Copy link
Copy Markdown
Collaborator

@juliannguyen4 juliannguyen4 commented Mar 23, 2026

Extra Changes

  • CI/CD: Fix bug where run-ee-server.bash doesn't use the correct image and tag because of setting the wrong environment variable
  • CI/CD: Remove references to Docker Hub credentials. From now on I believe we are storing server RC's in JFrog.
  • Bump jfrog CLI version in self-hosted Windows workflow to fix error where OIDC token can't be written
  • Add cross reference for path expressions / operations to the context methods that can be used
  • Refactor aerospike_helpers.cdt_ctx conversion code by moving individual _cdt_ctx conversion to a separate method. This reduces the number of indents in the get_cdt_ctx helper function.
  • Remove some unused imports in test_path_expressions.py

Out of scope / Not enough time

  • Move path expressions into their own section. Deprecate the usage in the base package
  • Document why we have QOL improvements via cross references

Docs

Manual testing

  • Reviewed valgrind and found no memory errors. I don't believe there's new leaks from this PR
  • Build artifacts passes against latest server 8.1.2 RC
  • Massif memory usage looks ok
  • Code coverage of diff is 92%. Code coverage report comment is outdated and history shows the actual code coverage.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 91.07143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.86%. Comparing base (274742f) to head (6292a36).
⚠️ Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 90.29% 13 Missing ⚠️
src/main/convert_expressions.c 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1002      +/-   ##
==========================================
+ Coverage   83.83%   83.86%   +0.03%     
==========================================
  Files          99       99              
  Lines       14429    14489      +60     
==========================================
+ Hits        12096    12151      +55     
- Misses       2333     2338       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-4436-path-expressions-improvements branch from 079f321 to 86f7f3f Compare March 25, 2026 16:24
…age "invalid id from <host>:<port>". Info command looks correct so not sure why this happens
…use the shared worklow's setup-aerospike-server action in a future PR
…ion where a server RC may be fetched via OIDC
…ure why called jobs are failing. But it's best practice to be explicit with permissions
…n return NULL. Following a lead from server team where ListBin named list_of_ints2 is missing 0x3
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-4436-path-expressions-improvements branch from 197bcd5 to 35e6136 Compare April 8, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants