[CLIENT-4313] Support creating set indexes with "sindex-admin" role#1001
Draft
juliannguyen4 wants to merge 30 commits intodevfrom
Draft
[CLIENT-4313] Support creating set indexes with "sindex-admin" role#1001juliannguyen4 wants to merge 30 commits intodevfrom
juliannguyen4 wants to merge 30 commits intodevfrom
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1001 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 99 99
Lines 14429 14437 +8
=======================================
+ Hits 12096 12103 +7
- Misses 2333 2334 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…eating-set-indexes-with-sindex-admin-role
…AS_INDEX_NONE. I incorrectly assumed that passing NULL to both bin name and expr would implicitly create a set index
…est can't detect this because these kwargs are defined at runtime
juliannguyen4
force-pushed
the
CLIENT-4313-support-creating-set-indexes-with-sindex-admin-role
branch
from
3c93726 to
7ff71c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra Changes
Type stubs: fix admin commands having the wrong parameter name for username. The actual name is "user" .
TODO: test is probably EE only
TODO test type stub changes...