Skip to content

fix(contrast-colors): replace depreciated colorspace#281

Open
karim-semmoud wants to merge 3 commits intoadobe:mainfrom
karim-semmoud:fix-depreciated-colorspace
Open

fix(contrast-colors): replace depreciated colorspace#281
karim-semmoud wants to merge 3 commits intoadobe:mainfrom
karim-semmoud:fix-depreciated-colorspace

Conversation

@karim-semmoud
Copy link
Copy Markdown

@karim-semmoud karim-semmoud commented Mar 26, 2026

Description

This PR aims at replacing the depreciated use of colorspace in favor of colorSpace across Contrast Colors lib, test and documentation

Closes #280

Motivation

This allows a better developer experience by removing the depreciated log and lint message on the latest version

To-do list

  • [ x] I have read the CONTRIBUTING document.
  • [x ] Local test passes using moon
  • This pull request is ready to merge.

Note

Despite the colorspace still available for backward compatibility, the update of the README only refers to the latest colorSpace naming

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

⚠️ No Changeset found

Latest commit: 079bbdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@karim-semmoud karim-semmoud changed the title Fix(contrast-colors): replace depreciated colorspace fix(contrast-colors): replace depreciated colorspace Mar 26, 2026
Copy link
Copy Markdown
Author

@karim-semmoud karim-semmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CLI test to be approved and pass before marking this PR as "ready to merge"
Note: Test are passing locally with moon and ava

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backgroundcolor.js is using depreciated colorspace

1 participant