FEATURE: Refresh stale data element references across entire property#1513
Open
Spencer-Smith wants to merge 4 commits into
Open
FEATURE: Refresh stale data element references across entire property#1513Spencer-Smith wants to merge 4 commits into
Spencer-Smith wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 4282de7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Packages
Description
Added a button (with a new accordion section as it did not fit in any of the existing ones) to the extension configuration page that allows users to scan all rules within a property with action settings referring to data elements outside of itself. When found, attempts repair:
dataElementNameand a DE with that name is in the repo, sets thedataElementIdto that DEdataElementNameis in the repo or nodataElementNameexists, it performs a global lookup on thedataElementId(ie, outside of the property) and if one is found, compares that DE's name to DEs within the repo and sets the dataElementId to that DERelated Issue
N/A
Motivation and Context
References to data elements in extension settings do not have those references updated when a property or rule is copied and instead continue pointing to DEs in the original property. These actions will not work as intended when the property is compiled because of the broken references. Currently a workaround exists where if a user opens the action in question, the extension view attempts to find and repair these broken references. However, this requires users to open each action on a copied property and re-save them.
These new changes add functionality at the property-level to scan and repair all actions with the push of a button (as described above).
Screenshots (if appropriate):
Repair panel view
Confirmation dialog
Repair panel view after repair failure
Repair panel view after successful repair
Dialog with report after successful repair
Documentation
TODO: Add doc ticket
Types of changes
Checklist: