Skip to content

chore: upgrade @oclif/core from v2 to v4 and migrate to ESLint 9#120

Open
shazron wants to merge 2 commits intomasterfrom
fix/issue-119-oclif-core-v4-upgrade
Open

chore: upgrade @oclif/core from v2 to v4 and migrate to ESLint 9#120
shazron wants to merge 2 commits intomasterfrom
fix/issue-119-oclif-core-v4-upgrade

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Mar 25, 2026

Fixes #119

  • Update @oclif/core dependency to ^4.10.2
  • Move this.parse() inside try/catch in info.js (v4 parse() calls config.runHook internally)
  • Spread config.plugins.values() since config.plugins is now a Map in v4
  • Add runHook mock to test configs to satisfy v4's parse() lifecycle
  • Allow @oclif/core in node/no-missing-require rule (eslint-plugin-node@11 doesn't resolve package.json exports field)
  • migrate to eslint v9 flat config with @adobe/eslint-config-aio-lib-config@5

How Has This Been Tested?

  • npm test
  • ./bin/run info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Update @oclif/core dependency to ^4.10.2
- Move this.parse() inside try/catch in info.js (v4 parse() calls config.runHook internally)
- Spread config.plugins.values() since config.plugins is now a Map in v4
- Add runHook mock to test configs to satisfy v4's parse() lifecycle
- Allow @oclif/core in node/no-missing-require rule (eslint-plugin-node@11 doesn't resolve package.json exports field)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…-lib-config@5

- Replace .eslintrc.json, test/.eslintrc.json, e2e/.eslintrc.json with eslint.config.js
- Update devDependencies: eslint@^9, @adobe/eslint-config-aio-lib-config@^5,
  eslint-plugin-jest@^29, eslint-plugin-jsdoc@^48, neostandard@^0
- Drop node/no-missing-require allowlist for @oclif/core (eslint-plugin-n v17
  supports package.json exports field natively)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@shazron shazron changed the title chore: upgrade @oclif/core from v2 to v4 (fixes #119) chore: upgrade @oclif/core from v2 to v4 and migrate to ESLint 9 Mar 25, 2026
Copy link
Copy Markdown
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little nit

@@ -0,0 +1,28 @@
/*
Copyright 2020 Adobe. All rights reserved.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 2026 since it is new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: update @oclif/core to latest version

2 participants