Skip to content

update yeoman-environment to v4#926

Open
hannah-taub-1 wants to merge 1 commit into
masterfrom
ACNA-4501/update-yeoman-environment
Open

update yeoman-environment to v4#926
hannah-taub-1 wants to merge 1 commit into
masterfrom
ACNA-4501/update-yeoman-environment

Conversation

@hannah-taub-1
Copy link
Copy Markdown
Contributor

Description

Update the yeoman-environment module to v4.

Related Issue

https://jira.corp.adobe.com/browse/ACNA-4609

Motivation and Context

Reduce deprecation warnings when updating aio-cli.

How Has This Been Tested?

  • Ran unit tests
  • Linked plugin and ran aio app create

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

The diff upgrades yeoman-environment from v3 to v4 (ESM-only) by wrapping the dynamic import in a thin CJS shim. The approach is sound and the tests are updated consistently. One minor issue: the copyright year in the new file header is '2026' (a future year), and there is a missing error handling consideration for the dynamic import failure case, but neither is a blocking problem.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

Comment thread src/lib/create-yeoman-environment.js
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no issues. Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants