Skip to content

feat: support loading actions in esm environments#167

Closed
ahmed-musallam wants to merge 1 commit into
adobe:mainfrom
ahmed-musallam:feat-support-esm
Closed

feat: support loading actions in esm environments#167
ahmed-musallam wants to merge 1 commit into
adobe:mainfrom
ahmed-musallam:feat-support-esm

Conversation

@ahmed-musallam
Copy link
Copy Markdown

@ahmed-musallam ahmed-musallam commented May 15, 2026

Description

Fixes an issue where projects that have type: "module" in their package.json cannot serve actions locally via aio app dev due to the loader expecting esm.

This fix dynamically adds a package.json whose contents are {"type":"commonjs"} next to the dist action to denote it as commonjs for the loader.

tested on this app:
https://github.com/adobe/appbuilder-quickstarts/tree/master/typescript-app

Related Issue

https://jira.corp.adobe.com/browse/IOEXT-1726

Motivation and Context

How Has This Been Tested?

coverage maintained.

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ahmed-musallam
Copy link
Copy Markdown
Author

Closing, in favor of: adobe/aio-lib-runtime#230
which is a more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant