fix: Return null instead of Kotlin.Unit over method channel for AEPMessaging#159
Open
Psyaryu wants to merge 1 commit into
Open
fix: Return null instead of Kotlin.Unit over method channel for AEPMessaging#159Psyaryu wants to merge 1 commit into
Psyaryu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Empty return types in Kotlin functions return an object noted as Kotlin.Unit. which is not supported by Flutter BinaryMessenger .
flutter_aepmessagingthrows a native exception regardingKotlin.Unitbeing an unsupported type when callingMessaging.refershInAppMessages(). This native exception is never received on the Flutter side.This update addresses all aepsdk_flutter 5.0.1 plugins passing Kotlin functions with undefined types to
MethodChannel.Resultby explicitly passingnullThe plugins affected are
flutter_aepmessagingRelated Issue
Motivation and Context
While refreshing Adobe In-App Messages on Android via the Dart SDK, this issue was found. It is unknown the impact of the issue.
If a critical issue is not resolved, at least there's no more errors being reported in the logs.
How Has This Been Tested?
This issue is evident by writing an integration test for the example project and running the integration test on an Android device
Screenshots (if appropriate):
Before:

After:

Types of changes
Checklist: