Messaging Presentable Update: Fix for safe drawing area and inheriting original activity status bar theming#804
Closed
sagar-sharma-adobe wants to merge 3 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Closing this PR as a different approach is suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Message presentable currently does not take application settings for status bar into consideration leading to inaccurate UI sometimes.
Another issue is that safe drawign areas are not respected which means some interactable areas are hidden under status and navigation bar. Also the UX is not expected.
Related Issue
https://jira.corp.adobe.com/browse/MOB-24698
https://jira.corp.adobe.com/browse/MOB-24736
Motivation and Context
Orignal Behaviour:

The cross button is not interactable here. The status bar is also not visible since white icons get camouflaged in the in app message UI
How Has This Been Tested?
Screenshots (if appropriate):
Here is a screenshot with proper theming inheritance.

As can be observed this shows the proper theme but layout still over bleeds.
With both fixes in place here is the final layout:
Types of changes
Checklist: