Skip to content

Messaging Presentable Update: Fix for safe drawing area and inheriting original activity status bar theming#804

Closed
sagar-sharma-adobe wants to merge 3 commits into
adobe:mainfrom
sagar-sharma-adobe:platir_62063
Closed

Messaging Presentable Update: Fix for safe drawing area and inheriting original activity status bar theming#804
sagar-sharma-adobe wants to merge 3 commits into
adobe:mainfrom
sagar-sharma-adobe:platir_62063

Conversation

@sagar-sharma-adobe
Copy link
Copy Markdown
Contributor

@sagar-sharma-adobe sagar-sharma-adobe commented Mar 26, 2026

Description

Message presentable currently does not take application settings for status bar into consideration leading to inaccurate UI sometimes.
Another issue is that safe drawign areas are not respected which means some interactable areas are hidden under status and navigation bar. Also the UX is not expected.

Related Issue

https://jira.corp.adobe.com/browse/MOB-24698
https://jira.corp.adobe.com/browse/MOB-24736

Motivation and Context

Orignal Behaviour:
Screenshot 2026-03-27 at 1 23 16 AM
The cross button is not interactable here. The status bar is also not visible since white icons get camouflaged in the in app message UI

How Has This Been Tested?

Screenshots (if appropriate):

Here is a screenshot with proper theming inheritance.
Screenshot 2026-03-27 at 1 23 49 AM

As can be observed this shows the proper theme but layout still over bleeds.

With both fixes in place here is the final layout:

Screenshot 2026-03-27 at 2 07 41 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...keting/mobile/services/ui/message/views/Message.kt 80.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@sagar-sharma-adobe
Copy link
Copy Markdown
Contributor Author

Closing this PR as a different approach is suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant