Fix initialization checks in Mat classes to handle '0' values#52
Open
emilneander wants to merge 1 commit into
Open
Fix initialization checks in Mat classes to handle '0' values#52emilneander wants to merge 1 commit into
emilneander wants to merge 1 commit into
Conversation
- Previously, the Mat classes conflated 0 with undefined or null due to truthy/falsy checks. This commit ensures that 0 is treated as a valid value by explicitly checking for undefined during initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
MatInitialization withCvTypeConstantsProblem:
When using certain
CvTypeconstant with a value of0(CvType.CV_8U), theMatclass was not initializing correctly due to truthy/falsy checks in the constructor.Solution:
Explicitly check for
undefinedvalues in theMatclass constructor to ensure that values like0are treated as valid.Changes:
Matclass constructor to explicitly check forundefined.0values correctly.Example:
The issue was evident when using the
CvTypeconstants: