Update dependencies and replace deprecated guava usage#378
Open
jekh wants to merge 1 commit intoadamfisk:masterfrom
Open
Update dependencies and replace deprecated guava usage#378jekh wants to merge 1 commit intoadamfisk:masterfrom
jekh wants to merge 1 commit intoadamfisk:masterfrom
Conversation
…f guava. Replaced now-removed HostAndPort.getHostText() with .getHost().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of guava's HostAndPort.getHostText() with .getHost(). Guava deprecated .getHostText() in 20 (Oct 2016), and removed it completely from 22 (May 2017). As a result, nobody using guava 22 can use LittleProxy.
This PR also bumps a few other dependency versions, including netty.