Remove six dependency and use Python 3 stdlib urllib#133
Merged
Conversation
The project requires Python >=3.9, so six (a Python 2/3 compat library) is unnecessary. Replace all six.moves.urllib imports in examples with their stdlib equivalents and remove six from test dependencies. https://claude.ai/code/session_01Up7npYZdfHZ4A4fpzFTAo2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on the
sixcompatibility library by replacing allsix.moves.urllibimports with their Python 3 standard library equivalents.Summary
The
sixlibrary was used to provide Python 2/3 compatibility for urllib imports. Since Python 2 is no longer supported, we can use the native Python 3urllibmodule directly.Changes Made
from six.moves.urllib import parsewithfrom urllib import parsein multiple example filesfrom six.moves.urllib.parse import quotewithfrom urllib.parse import quotefrom six.moves.urllib_parse import urljoinwithfrom urllib.parse import urljoinsixfrom the test dependencies inpyproject.tomlFiles Modified
examples/sync_funcaptcha_selenium.pyexamples/sync_funcaptcha_request.pyexamples/sync_funcaptcha_selenium_callback.pyexamples/sync_hcaptcha_request_proxy.pyexamples/sync_recaptcha3_request.pypyproject.tomlThis change simplifies the codebase and reduces external dependencies while maintaining full functionality.
https://claude.ai/code/session_01Up7npYZdfHZ4A4fpzFTAo2