[Fix] Remove redundant cookies serialization from ProxyMixin#111
Merged
Conversation
ProxyMixin.serialize referenced self.cookies but ProxyMixin doesn't define it — relying on CookieMixin being in the MRO. This would crash if ProxyMixin were composed without CookieMixin. The block was also redundant since CookieMixin.serialize already handles cookies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.cookiesreference fromProxyMixin.serializewhich would crash ifProxyMixinwere used withoutCookieMixinin the MROCookieMixin.serializealready handles cookies serialization via the cooperative MRO chainTest plan
ProxyMixinandCookieMixin)NoCaptchaTask,FunCaptchaTask,HCaptchaTask🤖 Generated with Claude Code