Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds initial support for Disdromet RD-80 disdrometer processing by introducing a new RD-80 Level 1b converter and a new internal disdronator reader package, plus a small plotting tweak and a unit test + sample file.
Changes:
- Add
rd802ncconverter for Disdromet RD-80 and register it incloudnetpy.instruments. - Introduce new
cloudnetpy.disdronatorreaders (RD-80 + Parsivel + LPM) and shared parsing utilities. - Update plotting metadata to mask zeros for
number_concentration, and extend mypy overrides forcftime.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_disdrometer.py | Adds a unit test for the new RD-80 converter output. |
| tests/unit/data/rd80/RD-211231-181400.txt | Adds a small RD-80 sample input file for tests. |
| pyproject.toml | Ignores missing type stubs for cftime.* in mypy. |
| cloudnetpy/plotting/plot_meta.py | Masks zeros when plotting number_concentration. |
| cloudnetpy/instruments/instruments.py | Registers the RD-80 instrument metadata. |
| cloudnetpy/instruments/disdrometer/rd80.py | Implements RD-80 → Cloudnet Level 1b conversion. |
| cloudnetpy/instruments/disdrometer/init.py | Exposes rd802nc from the disdrometer subpackage. |
| cloudnetpy/instruments/init.py | Re-exports rd802nc alongside other instrument converters. |
| cloudnetpy/disdronator/utils.py | Adds shared conversion helper for parsing outputs into numpy arrays. |
| cloudnetpy/disdronator/rd80.py | Adds RD-80 ASCII reader + bin constants. |
| cloudnetpy/disdronator/parsivel.py | Adds Parsivel reader supporting multiple formats. |
| cloudnetpy/disdronator/lpm.py | Adds LPM reader for multiple formats. |
| cloudnetpy/disdronator/init.py | Exposes reader entry points from the new package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.