Skip to content

Scope test lockfiles by package manager and update cache tests #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gowridurgad wants to merge 3 commits into
base: main
Choose a base branch
from
+329 −3,350
Open

Scope test lockfiles by package manager and update cache tests #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc273c4
fix security alerts
Feb 11, 2026
fb13873
fix security alerts
Feb 20, 2026
584350e
address Copilot suggestions
Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,18 @@ typings/

# DynamoDB Local files
.dynamodb/

# Ignore everything inside fixture package-manager folders
__tests__/data/npm/**
__tests__/data/pnpm/**
__tests__/data/yarn/**

# Keep only fixture manifests + lockfiles
!__tests__/data/npm/package.json
!__tests__/data/npm/package-lock.json

!__tests__/data/pnpm/package.json
!__tests__/data/pnpm/pnpm-lock.yaml

!__tests__/data/yarn/package.json
!__tests__/data/yarn/yarn.lock
23 changes: 19 additions & 4 deletions __tests__/cache-restore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ import * as utils from '../src/cache-utils';
import {restoreCache} from '../src/cache-restore';

describe('cache-restore', () => {
process.env['GITHUB_WORKSPACE'] = path.join(__dirname, 'data');
const packageManagers = ['yarn', 'npm', 'pnpm'] as const;
type PackageManager = (typeof packageManagers)[number];

const setWorkspaceFor = (pm: PackageManager) => {
process.env['GITHUB_WORKSPACE'] = path.join(__dirname, 'data', pm);
};
const originalGithubWorkspace = process.env['GITHUB_WORKSPACE'];
if (!process.env.RUNNER_OS) {
process.env.RUNNER_OS = 'Linux';
}
Expand All @@ -25,7 +31,7 @@ describe('cache-restore', () => {
'abf7c9b306a3149dcfba4673e2362755503bcceaab46f0e4e6fee0ade493e20c';
const pnpmFileHash =
'26309058093e84713f38869c50cf1cee9b08155ede874ec1b44ce3fca8c68c70';
const cachesObject = {
const cachesObject: Record<string, string> = {
[npmCachePath]: npmFileHash,
[pnpmCachePath]: pnpmFileHash,
[yarn1CachePath]: yarnFileHash,
Expand Down Expand Up @@ -128,9 +134,11 @@ describe('cache-restore', () => {
['yarn', '1.2.3', yarnFileHash],
['npm', '', npmFileHash],
['pnpm', '', pnpmFileHash]
])(
] as const)(
'restored dependencies for %s',
async (packageManager, toolVersion, fileHash) => {
// Set workspace to the appropriate fixture folder
setWorkspaceFor(packageManager);
getCommandOutputSpy.mockImplementation((command: string) => {
if (command.includes('version')) {
return toolVersion;
Expand Down Expand Up @@ -158,9 +166,11 @@ describe('cache-restore', () => {
['yarn', '1.2.3', yarnFileHash],
['npm', '', npmFileHash],
['pnpm', '', pnpmFileHash]
])(
] as const)(
'dependencies are changed %s',
async (packageManager, toolVersion, fileHash) => {
// Set workspace to the appropriate fixture folder
setWorkspaceFor(packageManager);
getCommandOutputSpy.mockImplementation((command: string) => {
if (command.includes('version')) {
return toolVersion;
Expand All @@ -181,6 +191,11 @@ describe('cache-restore', () => {
});

afterEach(() => {
if (originalGithubWorkspace === undefined) {
delete process.env['GITHUB_WORKSPACE'];
} else {
process.env['GITHUB_WORKSPACE'] = originalGithubWorkspace;
}
jest.resetAllMocks();
jest.clearAllMocks();
});
Expand Down
109 changes: 109 additions & 0 deletions __tests__/data/npm/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions __tests__/data/npm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "npm-fixture",
"engines": {
"node": "^24.0.0"
},
"dependencies": {
"accepts": "^1.3.8",
"array-flatten": "^3.0.0",
"bytes": "^3.1.2",
"content-disposition": "^0.5.4"
}
}
Loading
Loading