Skip to content

fix!: return ArrayBuffer-backed arrays#98

Merged
achingbrain merged 3 commits into
mainfrom
fix/return-array-buffer-backed-arrays
May 7, 2026
Merged

fix!: return ArrayBuffer-backed arrays#98
achingbrain merged 3 commits into
mainfrom
fix/return-array-buffer-backed-arrays

Conversation

@achingbrain
Copy link
Copy Markdown
Owner

@achingbrain achingbrain commented May 4, 2026

Since microsoft/TypeScript#59417 Uint8Arrays backed by ArrayBuffer are incompatible with those backed with SharedArrayBuffer so be explicit about the types returned.

BREAKING CHANGE: where Uint8Array was returned, now Uint8Array<ArrayBuffer>is returned instead

Since microsoft/TypeScript#59417 `Uint8Array`s
backed by `ArrayBuffer` are incompatible with those backed with
`SharedArrayBuffer` so be explicit about the types returned.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.34%. Comparing base (385701f) to head (ad3f364).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/util/as-uint8array.node.ts 50.00% 4 Missing ⚠️
src/util/as-uint8array.ts 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   99.05%   95.34%   -3.71%     
==========================================
  Files          24       16       -8     
  Lines         633      344     -289     
  Branches      117       71      -46     
==========================================
- Hits          627      328     -299     
- Misses          6       16      +10     
Flag Coverage Δ
chrome 95.41% <77.77%> (-1.98%) ⬇️
node 92.79% <71.42%> (-5.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@achingbrain achingbrain changed the title fix: return ArrayBuffer-backed arrays fix!: return ArrayBuffer-backed arrays May 7, 2026
@achingbrain achingbrain merged commit f345af0 into main May 7, 2026
23 of 25 checks passed
@achingbrain achingbrain deleted the fix/return-array-buffer-backed-arrays branch May 7, 2026 07:12
github-actions Bot pushed a commit that referenced this pull request May 7, 2026
## [6.0.0](v5.1.1...v6.0.0) (2026-05-07)

### ⚠ BREAKING CHANGES

* where `Uint8Array` was returned, now `Uint8Array<ArrayBuffer>`is returned instead

### Bug Fixes

* return ArrayBuffer-backed arrays ([#98](#98)) ([f345af0](f345af0))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant