fix: expose currentTime and utcOffset to template logic in trigger() and init()

[Sup-ri-tha]

Fixes #115

Problem

trigger() and init() in TemplateArchiveProcessor pass currentTime and utcOffset in the arguments array but omit them from argumentNames.

evalDangerously() builds new Function(...argumentNames, code) - only named arguments are accessible inside the function. As a result, currentTime and utcOffset silently become undefined with no error or warning. [Confirmed via console.log in logic.ts , currentTime is undefined despite being passed by the caller.]

Proof

Fix

Added missing names to argumentNames in both trigger() and init():

// trigger()
argumentNames: ['data', 'request', 'state', 'currentTime', 'utcOffset'],

// init()
argumentNames: ['data', 'currentTime', 'utcOffset'],

Also fixed JSDoc typo: "UTC offer" → "UTC offset" in both methods.

Testing

All existing tests pass. The two failing tests (stress test, optional-nested) are pre-existing and unrelated to this change.

Checklist

• Code follows project conventions
• All tests pass
• DCO sign-off included

[Copilot]

Pull request overview

This PR aims to make currentTime and utcOffset available to template logic executed by TemplateArchiveProcessor.trigger() and init(), and corrects a JSDoc typo.

Changes:

• Add currentTime/utcOffset to the argumentNames arrays passed to evalDangerously() in trigger() and init().
• Fix JSDoc typo: “UTC offer” → “UTC offset”.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

argumentNames is not used by JavaScriptEvaluator.evalDangerously when templateLogic: true (it dynamic-imports the module and calls instance[functionName](...arguments)). As a result, adding currentTime/utcOffset here will not make them available as in-scope variables inside template logic unless the template logic method signature explicitly declares them. If the intent is to inject these into scope, the evaluator/path needs to change accordingly (or the logic API/types should be updated to include these optional parameters).

[Sup-ri-tha]

That's right. argumentNames is not used in the templateLogic path. Reverted those changes. Instead applied defaults for currentTime and utcOffset before passing them in arguments.

[Copilot]

The JSDoc says currentTime/utcOffset “default to now/zero”, but this method currently forwards the optional values as-is. If callers omit them, template logic will receive undefined; consider defaulting currentTime to new Date().toISOString() and utcOffset to 0 before constructing the arguments array to match the documented behavior.

[Sup-ri-tha]

Done. currentTime now defaults to new Date().toISOString() and utcOffset to 0 when not provided.

[Copilot]

argumentNames is not used by JavaScriptEvaluator.evalDangerously when templateLogic: true (module import + method call uses only arguments). This change likely won’t affect whether currentTime/utcOffset are accessible inside init() logic unless they are declared as parameters on the template logic method (or the evaluator/path is changed).

[Sup-ri-tha]

Reverted those changes and instead applied defaults for currentTime and utcOffset before passing them in arguments.

[Copilot]

The JSDoc says currentTime/utcOffset “default to now/zero”, but init() currently forwards the optional values as-is. Consider applying defaults before building the arguments array so template logic gets deterministic values when callers omit them.

[Sup-ri-tha]

Done. currentTime now defaults to new Date().toISOString() and utcOffset to 0 when not provided.

[Copilot]

The init() JSDoc @returns says “the response and any events”, but InitResponse in this file only contains state (no result/events). Please update the @returns description to match the actual return shape.

Suggested change

	* @returns {Promise} the response and any events
	* @returns {Promise<InitResponse>} the new state

[Sup-ri-tha]

Done.