Skip to content

fix: add explicit error when no TypeScript logic files are found in template#100

Open
FaikAijaz wants to merge 1 commit intoaccordproject:mainfrom
FaikAijaz:faikaijaz/fix-missing-typescript-logic
Open

fix: add explicit error when no TypeScript logic files are found in template#100
FaikAijaz wants to merge 1 commit intoaccordproject:mainfrom
FaikAijaz:faikaijaz/fix-missing-typescript-logic

Conversation

@FaikAijaz
Copy link

This PR improves the robustness of TemplateArchiveProcessor by explicitly handling the case where a template declares a TypeScript runtime but contains no TypeScript logic files.

Previously, if a template had "runtime": "typescript" but no logic/logic.ts file, the engine would fail with a generic runtime error:
Cannot read properties of undefined (reading 'code')
This occurred because the processor attempted to access compiled logic that did not exist.

Changes

Added a guard in both trigger() and init() to check whether any TypeScript logic files are present.
If no logic files are found, the processor now throws a clear and intentional error:

No TypeScript logic files found in template

Added a unit test (TemplateArchiveProcessor.noLogic.test.ts) to validate and protect this behavior.
This does not affect existing templates with valid TypeScript logic. It only improves behavior when logic files are missing.

Signed-off-by: FaikAijaz <faikaijaz635@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant