fix: add explicit error when no TypeScript logic files are found in template#100
Open
FaikAijaz wants to merge 1 commit intoaccordproject:mainfrom
Open
fix: add explicit error when no TypeScript logic files are found in template#100FaikAijaz wants to merge 1 commit intoaccordproject:mainfrom
FaikAijaz wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: FaikAijaz <faikaijaz635@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of TemplateArchiveProcessor by explicitly handling the case where a template declares a TypeScript runtime but contains no TypeScript logic files.
Previously, if a template had "runtime": "typescript" but no logic/logic.ts file, the engine would fail with a generic runtime error:
Cannot read properties of undefined (reading 'code')
This occurred because the processor attempted to access compiled logic that did not exist.
Changes
Added a guard in both trigger() and init() to check whether any TypeScript logic files are present.
If no logic files are found, the processor now throws a clear and intentional error:
No TypeScript logic files found in template
Added a unit test (TemplateArchiveProcessor.noLogic.test.ts) to validate and protect this behavior.
This does not affect existing templates with valid TypeScript logic. It only improves behavior when logic files are missing.