Skip to content

[clang] Make signed integer overflow defined with -fms-kernel #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eleviant wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[clang] Make signed integer overflow defined with -fms-kernel #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4075,8 +4075,7 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args,
// Set the handler, if one is specified.
Opts.OverflowHandler =
std::string(Args.getLastArgValue(OPT_ftrapv_handler));
}
else if (Args.hasArg(OPT_fwrapv))
} else if (Args.hasArg(OPT_fwrapv) || Opts.Kernel)
Opts.setSignedOverflowBehavior(LangOptions::SOB_Defined);

Opts.MSCompatibilityVersion = 0;
Expand Down
28 changes: 28 additions & 0 deletions clang/test/CodeGen/MSKernel/signed-overflow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// REQUIRES: x86-registered-target
// RUN: %clang_cc1 -fms-kernel -triple x86_64-windows-msvc -O2 -emit-llvm %s -o - | FileCheck %s
// CHECK: define {{.*}} i32 @add2(i32 noundef %a, i32 noundef %b)
// CHECK-NEXT: entry:
// CHECK-NEXT: %add = add i32 %b, %a
// CHECK-NEXT: ret i32 %add

// CHECK: define {{.*}} i32 @mul2(i32 noundef %a)
// CHECK-NEXT: entry:
// CHECK-NEXT: %mul = shl i32 %a, 1
// CHECK-NEXT: ret i32 %mul

// CHECK: define {{.*}} ptr @add_ptr(ptr noundef {{.*}} %base, i64 noundef %off)
// CHECK-NEXT: entry:
// CHECK-NEXT: %add.ptr = getelementptr i8, ptr %base, i64 %off
// CHECK-NEXT: ret ptr %add.ptr

int add2(int a, int b) {
return a + b;
}

int mul2(int a) {
return a*=2;
}

char* add_ptr(char* base, long long off) {
return base + off;
}