Update to neptune_driver/adaptor to connect to neptune-db; hybrid adapter connects to neptune-graph#22
Open
acarbonetto wants to merge 1 commit into
Open
Update to neptune_driver/adaptor to connect to neptune-db; hybrid adapter connects to neptune-graph#22acarbonetto wants to merge 1 commit into
acarbonetto wants to merge 1 commit into
Conversation
…id adaptor continues to use neptue-graph Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
|
|
||
| async def main(): | ||
| """ | ||
| Example script demonstrating how to use Cognee with Amazon Neptune Analytics |
Collaborator
There was a problem hiding this comment.
Suggested change
| Example script demonstrating how to use Cognee with Amazon Neptune Analytics | |
| Example script demonstrating how to use Cognee with Amazon Neptune Database |
| Example script demonstrating how to use Cognee with Amazon Neptune Analytics | ||
|
|
||
| This example: | ||
| 1. Configures Cognee to use Neptune Analytics as graph database |
| aws_secret_access_key: Optional[str] = None, | ||
| aws_session_token: Optional[str] = None, | ||
| self, | ||
| graph_id: str, |
Collaborator
There was a problem hiding this comment.
missing embedding_engine
Below is the error when running the original NA example.
File "/Users/andy.kwok/git/neptune/cognee/cognee/modules/data/deletion/prune_system.py", line 12, in prune_system
vector_engine = get_vector_engine()
^^^^^^^^^^^^^^^^^^^
File "/Users/andy.kwok/git/neptune/cognee/cognee/infrastructure/databases/vector/get_vector_engine.py", line 7, in get_vector_engine
return create_vector_engine(**get_vectordb_context_config())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/andy.kwok/git/neptune/cognee/cognee/infrastructure/databases/vector/create_vector_engine.py", line 140, in create_vector_engine
return NeptuneAnalyticsAdapter(
^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: NeptuneAnalyticsAdapter.__init__() got an unexpected keyword argument 'embedding_engine'
Owner
Author
There was a problem hiding this comment.
good catch. I'll re-add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…id adaptor continues to use neptue-graph
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.