Skip to content

Update to neptune_driver/adaptor to connect to neptune-db; hybrid adapter connects to neptune-graph#22

Open
acarbonetto wants to merge 1 commit into
mainfrom
acarbo/add_neptune_db
Open

Update to neptune_driver/adaptor to connect to neptune-db; hybrid adapter connects to neptune-graph#22
acarbonetto wants to merge 1 commit into
mainfrom
acarbo/add_neptune_db

Conversation

@acarbonetto
Copy link
Copy Markdown
Owner

…id adaptor continues to use neptue-graph

Description

DCO Affirmation

I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.

…id adaptor continues to use neptue-graph

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

async def main():
"""
Example script demonstrating how to use Cognee with Amazon Neptune Analytics
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example script demonstrating how to use Cognee with Amazon Neptune Analytics
Example script demonstrating how to use Cognee with Amazon Neptune Database

Example script demonstrating how to use Cognee with Amazon Neptune Analytics

This example:
1. Configures Cognee to use Neptune Analytics as graph database
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

aws_secret_access_key: Optional[str] = None,
aws_session_token: Optional[str] = None,
self,
graph_id: str,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing embedding_engine
Below is the error when running the original NA example.

 File "/Users/andy.kwok/git/neptune/cognee/cognee/modules/data/deletion/prune_system.py", line 12, in prune_system
    vector_engine = get_vector_engine()
                    ^^^^^^^^^^^^^^^^^^^
  File "/Users/andy.kwok/git/neptune/cognee/cognee/infrastructure/databases/vector/get_vector_engine.py", line 7, in get_vector_engine
    return create_vector_engine(**get_vectordb_context_config())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/andy.kwok/git/neptune/cognee/cognee/infrastructure/databases/vector/create_vector_engine.py", line 140, in create_vector_engine
    return NeptuneAnalyticsAdapter(
           ^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: NeptuneAnalyticsAdapter.__init__() got an unexpected keyword argument 'embedding_engine'

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I'll re-add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants