Conversation
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
…ionality Signed-off-by: Andre Bossard <anbossar@microsoft.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Fabric (workbench) UI to be more resilient when rendering/editing schema-driven outputs, and expands Playwright coverage (including a new mocked flow) around editing agents and observing run history.
Changes:
- Harden
SchemaRendererwidgets by normalizingx-uiconfig and handling more input shapes for tables/charts. - Revamp
SchemaEditorproperty UI and normalize schema/widget option parsing + serialization. - Add a mocked e2e test flow for “edit prompt changes next response while preserving history”, plus minor e2e stability tweaks; ignore
.mcp.json.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/workbench.spec.js | Adds serial mode, improves dialog close helper, and introduces a mocked edit-response/history e2e flow. |
| frontend/src/features/workbench/SchemaRenderer.jsx | Adds normalization helpers and makes table/chart widgets more defensive. |
| frontend/src/features/workbench/SchemaEditor.jsx | Refactors property editor layout and normalizes schema/widget option parsing/serialization. |
| frontend/src/features/workbench/AgentEditDialog.jsx | Adds dialog sizing/scroll styling for better usability. |
| .gitignore | Ignores .mcp.json. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+167
to
+179
| const resolvedUi = normalizeUiConfig(ui) | ||
| const firstRow = value.find((row) => row !== undefined && row !== null) | ||
| const columns = normalizeStringList(resolvedUi?.columns) | ||
| const fallbackColumns = isRecord(firstRow) ? Object.keys(firstRow) : ['value'] | ||
| const columnsToRender = columns.length > 0 ? columns : fallbackColumns | ||
|
|
||
| const renderCellValue = (row, column) => { | ||
| const cellValue = isRecord(row) || Array.isArray(row) ? row[column] : column === 'value' ? row : '' | ||
| if (typeof cellValue === 'object' && cellValue !== null) { | ||
| return JSON.stringify(cellValue) | ||
| } | ||
| return String(cellValue ?? '') | ||
| } |
| id: String(item[ui?.idKey || 'id'] || item.label || item.name || item), | ||
| value: item[ui?.valueKey || 'value'] || item.count || 0, | ||
| id: String(item[idKey] || item.label || item.name || item), | ||
| value: item[valueKey] || item.count || 0, |
Comment on lines
+6
to
12
| test.describe.configure({ mode: "serial" }); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // Helpers (zero mocks — all live) | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** Delete all agents whose name contains "e2e-", closing any open dialogs first. */ |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andre Bossard anbossar@microsoft.com