Draft
Conversation
Group admins with membership edit rights get a Close Group row in conversation settings. Confirming runs one GV2 update that removes every other member (same ban semantics as kick) and leaves, then soft-deletes the thread locally with delete-for-me sync. Co-authored-by: abedawi <abedawi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Close Group action in group conversation settings for GV2 group administrators who can edit membership. The flow confirms with copy that the action cannot be undone, then performs a single GV2 update that removes every other member (and pending state) with the same ban semantics as an individual kick, leaves the local user, and soft-deletes the thread locally with delete-for-me sync—matching the manual remove-all → leave → delete workflow.
Implementation
GroupManager.closeGroupForEveryoneV2composesremoveMember/addBannedMemberper existingremoveFromGroupOrRevokeInviteV2rules plussetShouldLeaveGroupDeclineInvite()in oneupdateGroupV2call.GroupViewUtils.updateGroupWithActivityIndicator, thenThreadSoftDeleteManager.softDeleteand pop to the conversation behind settings.Testing
xcodebuild/ Swift compiler are not available in this Linux environment; please build the Signal scheme on macOS and exercise an admin closing a small GV2 group (members + pending invites/requests).