Fix flaky "calls onread with errors" test#10
Merged
aaronik merged 1 commit intoaaronik:mainfrom May 15, 2025
Merged
Conversation
The `onerror` function got called multiple times, and we only stored the error of the last call. When the test was passing, it was called with these `err` values: 1. "ls:" 2. "cannot access '/thisdirdefinitelydoesntexistimsureofitforreal': No such file or directory" When the test was failing, it was called with these `err` values: 1. "ls:" 2. "cannot access '/thisdirdefinitelydoesntexistimsureofitforreal'" 3. ": No such file or directory" 4. "" (empty string, space or new line?) The solution is to store all the errors, not only the last.
Owner
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onerrorfunction got called multiple times, and we only stored the error of the last call.When the test was passing, it was called with these
errvalues:When the test was failing, it was called with these
errvalues:The solution is to store all the errors, not only the last.