GetFirstLiveMon Nomenclature and Littleroot Followers#49
Open
HashtagMarky wants to merge 2 commits intoaarant:followers-expanded-idfrom
Open
GetFirstLiveMon Nomenclature and Littleroot Followers#49HashtagMarky wants to merge 2 commits intoaarant:followers-expanded-idfrom
HashtagMarky wants to merge 2 commits intoaarant:followers-expanded-idfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As an expansion developer, I was recommended that I PR this here as it's related to the follower functions, but happy redirect it back if you wish.
When using the
FOLLOWERS_ALLOWED_Xdefines, theGetFirstLiveMonfunction (and others that rely on it) may result in aNULLvalue, even if a healthy non-egg is present in the party. While the current use case of these work as it is intended, the first commit in this PR updates the names of these functions to reflect this stipulation, in case users try using it elsewhere.The second commit in this PR updates the default value of
OW_MON_ALLOWED_MET_LOCtoMAPSEC_COUNT, as there will be unintended behaviour when trying to restrict followers to those given in Littleroot Town asMAPSEC_LITTLEROOT_TOWNhas a value of 0.Discord contact info
Contactable via this GitHub account or as HashtagMarky#4240 on Discord.