fix(client): align send_message signature with BaseClient

[Akshat8510]

Description

Aligned the send_message signature in Client with BaseClient.

Note: I used SendMessageConfiguration (instead of MessageSendConfiguration mentioned in the issue) because SendMessageConfiguration is the correct attribute name found in a2a_pb2, as verified by mypy.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Follow the CONTRIBUTING Guide.
• Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Important Prefixes for release-please:
    • fix: which represents bug fixes, and correlates to a SemVer patch.
    • feat: represents a new feature, and correlates to a SemVer minor.
    • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
• Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
• Appropriate docs were updated (if necessary)

Fixes #727 🦕

[gemini-code-assist]

Summary of Changes

Hello @Akshat8510, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the send_message method signature within the Client class to ensure consistency with BaseClient. This change introduces an optional SendMessageConfiguration parameter, improving API uniformity and adherence to defined interfaces.

Highlights

• Method Signature Alignment: The send_message method in src/a2a/client/client.py has been updated to align its signature with BaseClient, specifically by adding an optional configuration: SendMessageConfiguration | None = None parameter.
• Type Import: The SendMessageConfiguration type was imported from a2a.pb2 to support the updated send_message method signature.

Changelog

• src/a2a/client/client.py
  • Imported SendMessageConfiguration from a2a.pb2.
  • Modified the send_message method signature to accept an optional configuration parameter of type SendMessageConfiguration.

Activity

• Resolved issue [Bug]: Align send_message signature for BaseClient and Client #727.
• Confirmed the correct configuration type (SendMessageConfiguration) based on mypy verification, addressing a potential discrepancy with the original issue's suggestion.
• Completed all pre-submission checks, including following contributing guidelines, conventional commit specification, and passing tests/linter.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Akshat8510]

@gemini-code-assist/gemini review

[gemini-code-assist]

Code Review

This pull request correctly aligns the send_message method signature in the Client abstract base class with its implementation in BaseClient by adding the configuration parameter. This is a good fix that improves type consistency. I have one minor suggestion regarding import ordering to adhere to the project's formatting standards.

[gemini-code-assist]

Code Review

This pull request correctly aligns the send_message signature in the Client abstract base class with the BaseClient implementation by adding the configuration parameter. This is a good fix for consistency and likely resolves a type-checking error. I've only found one minor issue regarding import ordering, which I've commented on. Otherwise, the change is solid.

[Akshat8510]

@gemini-code-assist/gemini review

[gemini-code-assist]

Code Review

The pull request successfully aligns the send_message signature in Client with BaseClient by introducing the configuration parameter with the SendMessageConfiguration type. The changes are minimal, well-typed, and directly address the stated goal of the pull request. The use of SendMessageConfiguration is appropriate, as confirmed by the PR description regarding a2a_pb2.

[Akshat8510]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request standardizes the send_message method signature within the Client class to ensure consistency with BaseClient. This change introduces an optional SendMessageConfiguration parameter, improving API uniformity and adherence to defined interfaces, and resolves issue #727.

Highlights

• Method Signature Alignment: The send_message method in src/a2a/client/client.py has been updated to align its signature with BaseClient, specifically by adding an optional configuration: SendMessageConfiguration | None = None parameter.
• Type Import: The SendMessageConfiguration type was imported from a2a.pb2 to support the updated send_message method signature.

Changelog

• src/a2a/client/client.py
  • Imported SendMessageConfiguration from a2a.pb2.
  • Modified the send_message method signature to accept an optional configuration parameter of type SendMessageConfiguration.

Activity

• An initial summary of changes was provided by gemini-code-assist[bot].
• Author Akshat8510 requested a review from gemini-code-assist[bot] twice.
• Author Akshat8510 requested a summary from gemini-code-assist[bot].
• Review comments from gemini-code-assist[bot] highlighted that imports in src/a2a/client/client.py were not in alphabetical order, suggesting ruff format to fix it.

[Akshat8510]

Hi @ishymko, I aligned the send_message signature and added the necessary import. Note that I used SendMessageConfiguration (instead of MessageSendConfiguration) because I verified via mypy and the base_client.py file that this is the correct name in the current codebase.

Ready for your review!