Skip to content

V2 Changes to handle errors#7

Open
anudeepkalitkar wants to merge 4 commits intoZenduty:masterfrom
anudeepkalitkar:master
Open

V2 Changes to handle errors#7
anudeepkalitkar wants to merge 4 commits intoZenduty:masterfrom
anudeepkalitkar:master

Conversation

@anudeepkalitkar
Copy link
Copy Markdown

Omitted the older version "api"
handled any new keys in the response
added notifications api under accounts
added OncallV2
handled list incidents for get list of Incident Objects

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are customers who are still using the v1 configuration. So, we would need it ideally.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies accross all these files in apiv1.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have added the V1 files back to the code and made necessary changes to make it accessible

zenduty/setup.py Outdated
Comment on lines +9 to +13
author="Anudeep Kalitkar",
author_email="anudeep.kalitkar@gmail.com",
packages=find_packages(),
install_requires=[
"requests==2.32.3",
"urllib3==2.2.2",
"six==1.9.0",
"charset-normalizer==3.3.2",
"idna==3.7",
"urllib3==2.3.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anudeepkalitkar can you revert back this changes

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants