Skip to content

🎨 Palette: Add visual focus indicators to interactive elements#52

Open
manupawickramasinghe wants to merge 1 commit intomainfrom
palette/a11y-focus-indicators-16147346989076963877
Open

🎨 Palette: Add visual focus indicators to interactive elements#52
manupawickramasinghe wants to merge 1 commit intomainfrom
palette/a11y-focus-indicators-16147346989076963877

Conversation

@manupawickramasinghe
Copy link
Member

💡 What: Added visual focus indicators to custom and interactive elements.
🎯 Why: Elements with android:focusable="true" lacked clear visual states when focused. This is a critical accessibility issue, as users navigating via keyboard or D-pad cannot determine their current position on the screen.
📸 Before/After: Not applicable (XML changes).
♿ Accessibility: Ensures that keyboard/D-pad users can clearly see when they have focused on the STOP button or the framerate/bitrate tooltips.


PR created automatically by Jules for task 16147346989076963877 started by @manupawickramasinghe

Adds explicit `state_focused` styling to the custom STOP button (`btn_ios_background.xml`) using a white stroke. Also adds `?attr/selectableItemBackground` to the focusable `ftFeedback` and `qual_feedback` TextViews in `fragment_camera.xml`. This improves keyboard and directional pad navigation by making it visually clear which element has focus. Fixes `UnsafeImplicitIntentLaunch` lint error in `CameraFragment.kt` by explicitly setting the intent package name.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant