⚡ Cache MediaCodecList to speed up camera initialization#50
⚡ Cache MediaCodecList to speed up camera initialization#50manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
💡 **What:** Migrated the instantiation of `MediaCodecList(MediaCodecList.REGULAR_CODECS).codecInfos` to a `by lazy` property `cachedCodecInfos` inside the `companion object` of `CamEngine.kt`. Both `supportedEncodings` and `getEncoder` now consume this single statically cached list. 🎯 **Why:** Hardware codec discovery is an expensive, synchronous blocking system-level query that doesn't change outputs during an application's lifecycle. Previously, re-instantiating `CamEngine` or repeatedly requesting video encoders would invoke this costly operation continuously and pointlessly, bogging down initialization times. 📊 **Measured Improvement:** No direct baseline duration or formal benchmark values were captured since testing infrastructure and physical Android device access are absent in this environment. Nonetheless, it serves as a theoretically indisputable net performance improvement by eliminating duplicate system framework queries that incur both native allocations and IPC latency to the underlying `MediaCodec` framework. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Migrated the instantiation of
MediaCodecList(MediaCodecList.REGULAR_CODECS).codecInfosto aby lazypropertycachedCodecInfosinside thecompanion objectofCamEngine.kt. BothsupportedEncodingsandgetEncodernow consume this single statically cached list.🎯 Why: Hardware codec discovery is an expensive, synchronous blocking system-level query that doesn't change outputs during an application's lifecycle. Previously, re-instantiating
CamEngineor repeatedly requesting video encoders would invoke this costly operation continuously and pointlessly, bogging down initialization times.📊 Measured Improvement: No direct baseline duration or formal benchmark values were captured since testing infrastructure and physical Android device access are absent in this environment. Nonetheless, it serves as a theoretically indisputable net performance improvement by eliminating duplicate system framework queries that incur both native allocations and IPC latency to the underlying
MediaCodecframework.PR created automatically by Jules for task 11750180436579699289 started by @manupawickramasinghe