fix: tokenize first word on pipe/semicolon/ampersand in full persist mode#7
Open
eddydee123 wants to merge 1 commit into
Open
fix: tokenize first word on pipe/semicolon/ampersand in full persist mode#7eddydee123 wants to merge 1 commit into
eddydee123 wants to merge 1 commit into
Conversation
…mode `env|sort` (no space around pipe) was routed to the bash coprocess because `string split -m1 ' '` treated the whole string as one token, failing the `type -q` check. Use a regex that stops at shell operators so the actual command name is extracted regardless of whitespace. With help from AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env|sort(no space around pipe) was routed to the bash coprocess in full persist mode becausestring split -m1 ' 'treated the whole string as one token, failing thetype -qcheck. Use a regex that stops at shell operators so the actual command name is extracted regardless of whitespace.Let me know if you need me to create an Issue first.
Made with AI assistance (Claude)