Skip to content

Use direct Worker initialization when cross-origin isolation is active#23052

Closed
enricobattocchi wants to merge 1 commit intorelease/27.2from
feature/fix-worker-wp-70
Closed

Use direct Worker initialization when cross-origin isolation is active#23052
enricobattocchi wants to merge 1 commit intorelease/27.2from
feature/fix-worker-wp-70

Conversation

@enricobattocchi
Copy link
Copy Markdown
Member

This pull request updates the logic for creating web workers in createWorker.js to better handle environments where cross-origin isolation is enabled, such as when certain security headers are present. The main change ensures that blob URL workers are created correctly in these scenarios.

Worker creation improvements:

  • Updated createWorker to detect if window.crossOriginIsolated is true, and in that case, create the worker using the provided URL directly to avoid issues with blob URL workers and importScripts() failures.## Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug with WordPress 7.0 where the analysis was broken.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Mar 5, 2026
@vraja-pro vraja-pro deleted the branch release/27.2 March 17, 2026 09:20
@vraja-pro vraja-pro closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants