Skip to content

Automating the make release for task-processing - COMPINFRA-3567#229

Merged
EmanElsaban merged 1 commit into
masterfrom
u/emanelsabban/COMPINFRA-3567
May 15, 2026
Merged

Automating the make release for task-processing - COMPINFRA-3567#229
EmanElsaban merged 1 commit into
masterfrom
u/emanelsabban/COMPINFRA-3567

Conversation

@EmanElsaban
Copy link
Copy Markdown
Contributor

@EmanElsaban EmanElsaban commented May 14, 2026

automating the release process for this repo since its currently manual. We used to follow these steps before manually:

  • merge change
  • Make new version by changing version in init
  • git checkout master
  • git pull
  • git tag v0.6.0
  • git push origin master v0.6.0

then wait for jenkins to push the new release to pypi

Testing

  1. Triggered the guards locally:
  • tested modifying a tracked file (init.py) other than the makefile then running make release to see if it will fail with a warning and it did:
(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ make release
Error: working directory is not clean; only changes to Makefile are allowed when cutting a release.
make: *** [Makefile:37: release] Error 1
  • tested checking to another branch then running make release. It should fail and it did:
(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ make release
Error: must be on master branch.
make: *** [Makefile:38: release] Error 1

  • tested tag collision by attempting make release on the current tag and it failed with :
(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ make release
Error: tag v1.3.5 already exists and points at e3a4d336c00280bab6be052db31026d65e9ee761
make: *** [Makefile:39: release] Error 1
  1. Tested the full make target by commenting the push command and change the tag to v1.3.6 then verified that the commit and tag look right:
    output of make release: https://fluffy.yelpcorp.com/i/jlhvf5RBXPXSpFsmRZcBNcQgv529BPSz.html
(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ git log --oneline -2
b4750fd (HEAD -> u/emanelsabban/COMPINFRA-3567, tag: v1.3.6) Release v1.3.6
34182d0 (origin/u/emanelsabban/COMPINFRA-3567) Automating the make release for task-processing

and

(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ git tag -l | grep v1.3.6
v1.3.6

and

(py310) emanelsabban@dev208-uswest1adevc:~/pg/task_processing$ cat task_processing/__init__.py
__version__ = "1.3.6"

@EmanElsaban EmanElsaban force-pushed the u/emanelsabban/COMPINFRA-3567 branch from e3b9154 to 34182d0 Compare May 14, 2026 16:42
@EmanElsaban EmanElsaban merged commit 9bf2f45 into master May 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants